fix: rollup boost plan errors #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edobry
approved these changes
Jan 28, 2025
sigma
approved these changes
Feb 11, 2025
zhwrd
force-pushed
the
zhwrd/fix-rollup-boost
branch
from
2305510 to
d6440d5
Compare
zhwrd
pushed a commit
that referenced
this pull request
Feb 20, 2025
### Issue Rollup-boost encountered issues due to configuration drift. ### Description While the primary drift problem was resolved in [PR #147](#147), follow-up testing uncovered additional inconsistencies that require further adjustments. This issue proposes targeted fixes based on local test results and addresses the rest of inconsistencies. Also couple of uncovered bugs were addressed (mainly with external builder) Removed [this](https://github.com/ethpandaops/optimism-package/blob/0d490fd395ee579ea905bb4633e453e27e075bb8/src/el_cl_launcher.star#L354) as it was causing a bug + was confusing Changed behavior of builder consensus node. Now if external builder is used it should setup consensus node outside of enclave too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup boost nightly build is failing due to plan errors from merge / rebase issues